wgtmac commented on code in PR #194:
URL: https://github.com/apache/parquet-format/pull/194#discussion_r1134163134
##########
src/main/thrift/parquet.thrift:
##########
@@ -753,6 +753,9 @@ struct ColumnMetaData {
/** Byte offset from beginning of file to Bloom filter data. **/
14: optional i64 bloom_filter_offset;
+
+ /** Size of Bloom filter data, in bytes. **/
+ 15: optional i32 bloom_filter_length;
Review Comment:
On the writer side:
- Old writer only writes offset.
- New writer should write length as well.
On the reader size:
- Old reader only checks offset.
- New reader checks offset then try to use length if exists.
##########
src/main/thrift/parquet.thrift:
##########
@@ -753,6 +753,9 @@ struct ColumnMetaData {
/** Byte offset from beginning of file to Bloom filter data. **/
14: optional i64 bloom_filter_offset;
+
+ /** Size of Bloom filter data, in bytes. **/
+ 15: optional i32 bloom_filter_length;
Review Comment:
On the writer side:
- Old writer only writes offset.
- New writer should write length as well.
On the reader side:
- Old reader only checks offset.
- New reader checks offset then try to use length if exists.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
