[
https://issues.apache.org/jira/browse/PARQUET-2264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17709171#comment-17709171
]
ASF GitHub Bot commented on PARQUET-2264:
-----------------------------------------
wgtmac commented on code in PR #198:
URL: https://github.com/apache/parquet-format/pull/198#discussion_r1159239875
##########
LogicalTypes.md:
##########
@@ -219,7 +219,7 @@ decimal point, and the precision stores the maximum number
of digits supported
in the unscaled value.
If not specified, the scale is 0. Scale must be zero or a positive integer less
-than the precision. Precision is required and must be a non-zero positive
+than or equal to the precision. Precision is required and must be a non-zero
positive
Review Comment:
Thanks for the PR! Could you also add the comment to the thrift definition:
https://github.com/apache/parquet-format/blob/master/src/main/thrift/parquet.thrift#L253
?
> Update specification to allow DecimalType scale == precision
> ------------------------------------------------------------
>
> Key: PARQUET-2264
> URL: https://issues.apache.org/jira/browse/PARQUET-2264
> Project: Parquet
> Issue Type: Improvement
> Components: parquet-format
> Reporter: Devin Smith
> Priority: Minor
>
> The majority of implementations I've used allow for scale == precision.
> See https://github.com/apache/arrow-rs/pull/1607 for further motivation.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
