[
https://issues.apache.org/jira/browse/PARQUET-2336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17764603#comment-17764603
]
ASF GitHub Bot commented on PARQUET-2336:
-----------------------------------------
Fokko commented on code in PR #1134:
URL: https://github.com/apache/parquet-mr/pull/1134#discussion_r1324368223
##########
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/CodecFactory.java:
##########
@@ -248,13 +248,36 @@ protected CompressionCodec getCodec(CompressionCodecName
codecName) {
codecClass = configuration.getClassLoader().loadClass(codecClassName);
}
codec = (CompressionCodec) ReflectionUtils.newInstance(codecClass,
configuration);
- CODEC_BY_NAME.put(codecClassName, codec);
+ CODEC_BY_NAME.put(codecCacheKey, codec);
return codec;
} catch (ClassNotFoundException e) {
throw new BadConfigurationException("Class " + codecClassName + " was
not found", e);
}
}
+ private String cacheKey(CompressionCodecName codecName) {
+ String level = null;
+ switch (codecName) {
+ case GZIP:
+ level = configuration.get("zlib.compress.level");
+ break;
+ case BROTLI:
+ level = configuration.get("compression.brotli.quality");
+ break;
+ case ZSTD:
+ level = configuration.get("parquet.compression.codec.zstd.level");
+ if (level == null) {
+ // keep "io.compression.codec.zstd.level" for backwards compatibility
+ level = configuration.get("io.compression.codec.zstd.level");
Review Comment:
Thanks, let's remove it then 👍🏻
##########
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/CodecFactory.java:
##########
@@ -248,13 +248,36 @@ protected CompressionCodec getCodec(CompressionCodecName
codecName) {
codecClass = configuration.getClassLoader().loadClass(codecClassName);
}
codec = (CompressionCodec) ReflectionUtils.newInstance(codecClass,
configuration);
- CODEC_BY_NAME.put(codecClassName, codec);
+ CODEC_BY_NAME.put(codecCacheKey, codec);
return codec;
} catch (ClassNotFoundException e) {
throw new BadConfigurationException("Class " + codecClassName + " was
not found", e);
}
}
+ private String cacheKey(CompressionCodecName codecName) {
+ String level = null;
+ switch (codecName) {
+ case GZIP:
+ level = configuration.get("zlib.compress.level");
+ break;
+ case BROTLI:
+ level = configuration.get("compression.brotli.quality");
+ break;
+ case ZSTD:
+ level = configuration.get("parquet.compression.codec.zstd.level");
+ if (level == null) {
+ // keep "io.compression.codec.zstd.level" for backwards compatibility
+ level = configuration.get("io.compression.codec.zstd.level");
Review Comment:
Thanks, let's remove it then 👍🏻
> Add caching key to CodecFactory
> -------------------------------
>
> Key: PARQUET-2336
> URL: https://issues.apache.org/jira/browse/PARQUET-2336
> Project: Parquet
> Issue Type: Bug
> Components: parquet-hadoop
> Affects Versions: 1.13.1
> Reporter: Fokko Driesprong
> Assignee: Fokko Driesprong
> Priority: Major
> Fix For: 1.14.0
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
