[ https://issues.apache.org/jira/browse/PARQUET-2349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769184#comment-17769184 ]
ASF GitHub Bot commented on PARQUET-2349: ----------------------------------------- amousavigourabi opened a new pull request, #1155: URL: https://github.com/apache/parquet-mr/pull/1155 Make sure you have checked _all_ steps below. ### Jira - [x] My PR addresses the following [Parquet Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references them in the PR title. For example, "PARQUET-1234: My Parquet PR" - https://issues.apache.org/jira/browse/PARQUET-XXX - In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). ### Tests - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason: No new methods or business logic were added, only a few types to their supertypes, which are equivalent interfaces. ### Commits - [x] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Documentation - [x] In case of new functionality, my PR adds documentation that describes how to use it. - All the public functions and the classes in the PR contain Javadoc that explain what it does --- japicmp finds incompatibilities in two files, namely deleted methods/constructors. It is overly aggressive on this, these methods/constructors are not removed, but their signature is slightly modified in a compatible way. > Move from deprecated BytesCompressor/Decompressor to > BytesInputCompressor/Decompressor > -------------------------------------------------------------------------------------- > > Key: PARQUET-2349 > URL: https://issues.apache.org/jira/browse/PARQUET-2349 > Project: Parquet > Issue Type: Improvement > Components: parquet-hadoop > Reporter: Atour Mousavi Gourabi > Priority: Minor > > We currently have two pairs of equivalent compressor/decompressor interfaces > in CompressionCodecFactory and CodecFactory. > CompressionCodecFactory.BytesInputCompressor/Decompressor is located in > parquet-common, while CodecFactory.BytesCompressor/Decompressor is part of > parquet-hadoop and deprecated. Currently, a lot of methods use the deprecated > CodecFactory interfaces instead of the CompressionCodecFactory ones. As > CodecFactory.BytesCompressor/Decompressor already implements > CompressionCodecFactory.BytesInputCompressor/Decompressor, this is a > straight-forward change which does not introduce any breaking changes or harm > backwards compatibility. -- This message was sent by Atlassian Jira (v8.20.10#820010)