[ https://issues.apache.org/jira/browse/PARQUET-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17777862#comment-17777862 ]
ASF GitHub Bot commented on PARQUET-2355: ----------------------------------------- SinghAsDev commented on PR #1175: URL: https://github.com/apache/parquet-mr/pull/1175#issuecomment-1773046817 Hi @Fokko thanks for bringing this up. We at Pinterest still use Parquet thrift quite extensively. How urgent is thrift 0.19.0 upgrade and how much time can we wait before we absolutely need to upgrade thrift? Also, since elephantbird is not maintained anymore, one option would be to just get rid of elephantbird dependency completely, even if it means moving some code in parquet-mr. Thoughts? > Deprecate parquet-thrift > ------------------------ > > Key: PARQUET-2355 > URL: https://issues.apache.org/jira/browse/PARQUET-2355 > Project: Parquet > Issue Type: Improvement > Reporter: Fokko Driesprong > Assignee: Fokko Driesprong > Priority: Major > > I was in the process of updating to [the latest version of > Thrift|https://github.com/apache/parquet-mr/pull/1138] (from 0.16.0 to > 0.19.0). Mostly because it contains CVEs and makes the release process easier > because you don't have to install Thrift from source (it is just available on > homebrew etc). > > While working on this, I ran into an issue with Elephantbird, which is using > a very old version of Thrift (0.7.0). Trying to bump this I noticed that a > lot of classes that we use in the tests > [have|https://github.com/apache/parquet-mr/pull/1156] [ been made > private|https://github.com/apache/parquet-mr/pull/1156]. Therefore it is hard > to test if we break anything. > > It looks like parquet-thrift [is not used by anyone > anymore|https://mvnrepository.com/artifact/org.apache.parquet/parquet-thrift]. > I would suggest removing this from the repository unless anyone objects. -- This message was sent by Atlassian Jira (v8.20.10#820010)