Fokko commented on code in PR #1175:
URL: https://github.com/apache/parquet-mr/pull/1175#discussion_r1391631616
##########
parquet-thrift/src/main/java/org/apache/parquet/hadoop/thrift/ThriftReadSupport.java:
##########
@@ -41,21 +41,13 @@
import org.apache.parquet.thrift.projection.FieldProjectionFilter;
import org.apache.parquet.thrift.projection.StrictFieldProjectionFilter;
import org.apache.parquet.thrift.projection.ThriftProjectionException;
-import
org.apache.parquet.thrift.projection.deprecated.DeprecatedFieldProjectionFilter;
import org.apache.parquet.thrift.struct.ThriftType.StructType;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
+@Deprecated
public class ThriftReadSupport<T> extends ReadSupport<T> {
private static final Logger LOG =
LoggerFactory.getLogger(ThriftReadSupport.class);
-
- /**
- * Deprecated. Use {@link #STRICT_THRIFT_COLUMN_FILTER_KEY}
- * Accepts a ";" delimited list of globs in the syntax implemented by {@link
DeprecatedFieldProjectionFilter}
- */
- @Deprecated
Review Comment:
I'm also on a M1, and it takes quite a bit of effort to get Thrift compiled.
I got a patch ready to update Thrift to the latest version. I'm not sure if we
need to update `parquet-format` first, since the release is still on an older
version. I'll give it a try in a moment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@parquet.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
