[ https://issues.apache.org/jira/browse/PARQUET-2261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17789184#comment-17789184 ]
ASF GitHub Bot commented on PARQUET-2261: ----------------------------------------- ConeyLiu commented on code in PR #1177: URL: https://github.com/apache/parquet-mr/pull/1177#discussion_r1403534057 ########## parquet-column/src/main/java/org/apache/parquet/internal/column/columnindex/OffsetIndexBuilder.java: ########## @@ -116,11 +137,28 @@ private OffsetIndexBuilder() { * @param rowCount * the number of rows in the page */ + @Deprecated public void add(int compressedPageSize, long rowCount) { - add(previousOffset + previousPageSize, compressedPageSize, previousRowIndex + previousRowCount); + add(compressedPageSize, rowCount, Optional.empty()); + } + + /** + * Adds the specified parameters to this builder. Used by the writers to building up {@link OffsetIndex} objects to be + * written to the Parquet file. + * + * @param compressedPageSize + * the size of the page (including header) + * @param rowCount + * the number of rows in the page + * @param unencodedDataBytes + * the number of bytes of unencoded data of BYTE_ARRAY type + */ + public void add(int compressedPageSize, long rowCount, Optional<Long> unencodedDataBytes) { + add(previousOffset + previousPageSize, compressedPageSize, previousRowIndex + previousRowCount, unencodedDataBytes); previousRowCount = rowCount; } + Review Comment: blank line > [Format] Add statistics that reflect decoded size to metadata > ------------------------------------------------------------- > > Key: PARQUET-2261 > URL: https://issues.apache.org/jira/browse/PARQUET-2261 > Project: Parquet > Issue Type: New Feature > Components: parquet-format > Reporter: Micah Kornfield > Assignee: Micah Kornfield > Priority: Major > Fix For: format-2.10.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)