[jira] [Created] (PARQUET-145) InternalParquetRecordReader.close() should not throw an exception if initialization has failed

[wolfgang hoschek (JIRA)]

wolfgang hoschek created PARQUET-145:
----------------------------------------

             Summary: InternalParquetRecordReader.close() should not throw an 
exception if initialization has failed
                 Key: PARQUET-145
                 URL: https://issues.apache.org/jira/browse/PARQUET-145
             Project: Parquet
          Issue Type: Bug
    Affects Versions: parquet-mr_1.6.0
            Reporter: wolfgang hoschek


InternalParquetRecordReader.close() currently throws a NullPointerException if 
initialize() didn't succeed and hence the "reader" remains null. 

This NPE happens with client usage idioms like this:

{code}
AvroParquetReader reader = ...
try {
       // read some parquet data
} finally {
  if (reader != null) { reader.close(); }
}

I believe close() should read as follows:

{code}
public void close() throws IOException {
    if (reader != null) {
      reader.close();
    }
  }
{code}

Thoughts?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)