[ 
https://issues.apache.org/jira/browse/PARQUET-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14314071#comment-14314071
 ] 

Mick Davies commented on PARQUET-36:
------------------------------------

Hi Alex, 

I have already implemented the In and NotIn so I can perf test what I have done.

I am a bit stuck though cos the earlier PR, on which these changes are made, 
for PARQUET=36 is just sitting around - 
https://github.com/apache/incubator-parquet-mr/pull/117 
<https://github.com/apache/incubator-parquet-mr/pull/117>. The Travis CI build 
failed, but when I look at why it does not seem related to the changes I made, 
is this normally reliable? Also I can’t fully build locally due to issues 
getting thrift 0.7 on Mac OS 10.9+, which I noted in the PR conversation - I am 
not sure how that can be fixed.


Mick




> FilteringPrimitiveConverter should support dictionaries
> -------------------------------------------------------
>
>                 Key: PARQUET-36
>                 URL: https://issues.apache.org/jira/browse/PARQUET-36
>             Project: Parquet
>          Issue Type: Improvement
>          Components: parquet-mr
>            Reporter: Alex Levenson
>            Priority: Minor
>              Labels: filter2
>
> If the delegated PrimitiveConverter supports dictionaries, then 
> FilteringPrimitiveConverter should too.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to