File names (including binary files) need to include "-incubating" in them [1]. This is usually achieved by including it in the version string, e.g. 2.3.0-incubating.
Otherwise this looks good to me. Tom [1] http://incubator.apache.org/guides/releasemanagement.html#check-list On Mon, Feb 9, 2015 at 6:03 PM, Brock Noland <[email protected]> wrote: > On Mon, Feb 9, 2015 at 9:52 AM, Ryan Blue <[email protected]> wrote: > >> On 02/08/2015 06:10 PM, Brock Noland wrote: >> >>> +1 >>> >>> checked out NOTICE, LICENSE, all java files, etc and compiled source. >>> >>> misc: I don't understand why the maven repo has >>> "parquet-format-2.3.0-source-release.zip" >>> >> >> This is created by the maven plugin. I'll add it to the release process to >> delete this or update maven not to produce one, since it isn't needed. > > gotcha > >> >> >> nit: the maven repo has .asc.md5 and .asc.sha1 files which can be deleted >>> manually from the gui before closing the repo, but it's not required. >>> >> >> Is it best practice? Any idea why the maven plugin would produce these if >> they should be deleted by hand? > > > Not sure. I just noticed the Whirr release guide said delete them and I > have been coping it ever since. Generally it feels "cleaner" but has no > practical impact. > > >> >> >> rb >> >> -- >> Ryan Blue >> Software Engineer >> Cloudera, Inc. >>
