[ 
https://issues.apache.org/jira/browse/PDFBOX-558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jukka Zitting updated PDFBOX-558:
---------------------------------

    Fix Version/s:     (was: 0.8.0-incubator)

Seems like a reasonable change. However, I'm a bit worried about whether this 
would cause backwards compatibility issues for some clients. Would it be better 
to add a new method signature with this improvement and deprecate the old one?

> PDPageDestination getPageNumber only returns page number when underlying 
> COSArray has a page number
> ---------------------------------------------------------------------------------------------------
>
>                 Key: PDFBOX-558
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-558
>             Project: PDFBox
>          Issue Type: Improvement
>          Components: PDModel
>    Affects Versions: 0.8.0-incubator
>            Reporter: Wulf Berschin
>            Priority: Minor
>             Fix For: 1.0.0
>
>         Attachments: PDPageDestination_getPageNumber_extended.patch
>
>
> When a PDPagesDestinatin has a page referenced, getPageNumber returns (as 
> specified) -1.
> In contrast  other PD-Objects like PDOutlineItem are more "user-friendly" 
> findDestinationPage resloves thze stored reference. In my attached patch I 
> added code to getPageNumber  to return the page number for referenced PDPages 
> too.
> PDFBox Developers: Submit it to the code base if this fits the idea of the 
> PD-classes.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to