[
https://issues.apache.org/jira/browse/PDFBOX-777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12889496#action_12889496
]
Jukka Zitting commented on PDFBOX-777:
--------------------------------------
Looks good to me.
You may want to avoid using System.out prints and Exception.printStackTrace()
in the test case. A better alternative is usually to use JUnit assertions that
print out the message or the exception only when something unexpected happens.
There's also a general preference at Apache to avoid adding @author tags to
Java code since over time each file will most likely end up being revised by
many different authors. A better record of the authors of a given file can be
seen in the svn log. However, the PDFBox codebase has historically contained
lots of @author tags and we haven't really discussed whether we want to keep
adding/updating them or not, so either way is fine.
> Add utility class to easily extract a range of pages from a PDF
> ---------------------------------------------------------------
>
> Key: PDFBOX-777
> URL: https://issues.apache.org/jira/browse/PDFBOX-777
> Project: PDFBox
> Issue Type: New Feature
> Components: Utilities
> Reporter: Adam Nichols
> Assignee: Adam Nichols
> Fix For: 1.3.0
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> There's currently no utility to extract a range of pages (e.g. pages 3-7).
> This task adds a PageExtractor class and a corresponding JUnit test class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
