[ 
https://issues.apache.org/jira/browse/PDFBOX-896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12934034#action_12934034
 ] 

Adam Nichols commented on PDFBOX-896:
-------------------------------------

I noticed that (either before or after this patch), a NullPointerException will 
be thrown if paint() is called before calling setPage().  Since this NPE is not 
related to the functionality request, and since I'm not sure what the 
appropriate was to handle someone trying to paint() before they've setPage(), I 
just committed the patch as is.  The patch does improve functionality, and it 
doesn't create any new issues.

If anyone has any ideas on a better way to handle exceptions in paint(), rather 
than logging and ignoring them, please speak up.  I don't personally use these 
classes, so I'm not sure if it'd make sense to have paint() throw an exception 
or not...

Committed in revision 1037067

> PDFViewer doesn't render landscape mode correctly
> -------------------------------------------------
>
>                 Key: PDFBOX-896
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-896
>             Project: PDFBox
>          Issue Type: Bug
>    Affects Versions: 1.4.0
>         Environment: N/A
>            Reporter: Robert Stone
>            Priority: Minor
>             Fix For: 1.4.0
>
>         Attachments: landscapechange.diff
>
>
> When using the PDFViewer, landscape oriented documents are rendered 
> vertically rather than horizontally.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to