PrintPDF should not be case sensitive against printer name on Windows
---------------------------------------------------------------------
Key: PDFBOX-974
URL: https://issues.apache.org/jira/browse/PDFBOX-974
Project: PDFBox
Issue Type: Wish
Components: Utilities
Affects Versions: 1.5.0
Environment: Windows XP/ JRE 1.6.0_24
Reporter: Christophe Borivant
Priority: Minor
Microsoft Os are mostly non case sensitive.
If a printerName is given to PrintPDF, it looks for the provided string in a
case sensitive manner ( line around 115 ).
I made a little correction to the code to allow non case sensitive search on
Windows os :
I changed :
if(printService[i].getName().indexOf(printerName) != -1)
{
printJob.setPrintService(printService[i]);
printerFound = true;
}
to :
if (isWindows())
{
if(printService[i].getName().toLowerCase().indexOf(printerName.toLowerCase())
!= -1)
{
printJob.setPrintService(printService[i]);
printerFound = true;
}
}
else
{
if(printService[i].getName().indexOf(printerName) != -1)
{
printJob.setPrintService(printService[i]);
printerFound = true;
}
}
and added the method :
public static boolean isWindows()
{
String os = System.getProperty("os.name").toLowerCase();
return (os.indexOf( "win" ) >= 0);
}
I'm not sure it's the best way to do it, but at least, it works !
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
