[
https://issues.apache.org/jira/browse/PDFBOX-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13048368#comment-13048368
]
Thomas Chojecki commented on PDFBOX-1032:
-----------------------------------------
yes you're right. it's not improving the signing function at all.
The Closeable helps making the both classes more conforming. I'm using a helper
method that close streams and log IOExceptions. This method use Closeable as
parameter like Input- and Outputstreams.
Can you otherwise open a new issue for that improvement?
> Signing improvement (settable signature size)
> ---------------------------------------------
>
> Key: PDFBOX-1032
> URL: https://issues.apache.org/jira/browse/PDFBOX-1032
> Project: PDFBox
> Issue Type: Improvement
> Components: Writing
> Affects Versions: 1.6.0
> Reporter: Thomas Chojecki
> Attachments: signing_improvement.patch
>
>
> Here is a small patch that add a new setter and getter
> "preferedSignatureSize" to the SignatureOptions. So the user can set the
> approximate signature size on one's own.
> We use a small amount of bytes for the signature itself like 0x500 and
> additional calculate the size of the whole certificate chain that should be
> wrote inside the signature. This is much better than setting a fix signature
> size.
> If the user don't set any size, 0x2500 will be reserved.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
