Hi Andreas, no problem. Have you seen the pdfbox-checkstyle-5.xml I uploaded a couple of weeks ago? http://svn.apache.org/viewvc?rev=1151372&view=rev Just in case you're using Checkstyle 5.
I'm using that configuration now. I hope I didn't make any mistakes when upgrading the configuration to CS5. But maybe there is also no general consensus on what rules to enforce. If the Checkstyle configuration is fine for everyone, I'd encourage every committer to set it up in their IDE. On 10.08.2011 11:44:31 Andreas Lehmkühler wrote: > Hi, > > I have to check my eclipse settings, they obviously got lost somehow :-( > > Thanks for fixing this in svn Jeremias. > > BR > Andreas Lehmkühler > > ----- original Nachricht -------- > > Betreff: svn commit: r1156081 - > /pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDPage.java > Gesendet: Mi, 10. Aug 2011 > Von: [email protected] > > > Author: jeremias > > Date: Wed Aug 10 09:40:03 2011 > > New Revision: 1156081 > > > > URL: http://svn.apache.org/viewvc?rev=1156081&view=rev > > Log: > > Removed newly introduced tab characters. > > > > Modified: > > pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDPage.java > > > > Modified: > > pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDPage.java > > URL: > > http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pd > > fbox/pdmodel/PDPage.java?rev=1156081&r1=1156080&r2=1156081&view=diff > > ============================================================================ > > == > > --- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDPage.java > > (original) > > +++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/PDPage.java > > Wed Aug 10 09:40:03 2011 > > @@ -40,7 +40,6 @@ import java.awt.Dimension; > > import java.awt.Graphics; > > import java.awt.Graphics2D; > > import java.awt.image.BufferedImage; > > -import java.awt.image.ImagingOpException; > > import java.awt.print.PageFormat; > > import java.awt.print.Printable; > > import java.awt.print.PrinterException; > > @@ -716,21 +715,21 @@ public class PDPage implements COSObject > > Dimension pageDimension = new Dimension( (int)widthPt, > > (int)heightPt ); > > BufferedImage retval = null; > > float rotation = (float)Math.toRadians(findRotation()); > > - if (rotation != 0) > > + if (rotation != 0) > > { > > - retval = new BufferedImage( heightPx, widthPx, imageType ); > > + retval = new BufferedImage( heightPx, widthPx, imageType ); > > } > > else > > { > > - retval = new BufferedImage( widthPx, heightPx, imageType ); > > + retval = new BufferedImage( widthPx, heightPx, imageType ); > > } > > Graphics2D graphics = (Graphics2D)retval.getGraphics(); > > graphics.setBackground( TRANSPARENT_WHITE ); > > graphics.clearRect( 0, 0, retval.getWidth(), retval.getHeight() ); > > if (rotation != 0) > > { > > - graphics.translate(retval.getWidth(), 0.0f); > > - graphics.rotate(rotation); > > + graphics.translate(retval.getWidth(), 0.0f); > > + graphics.rotate(rotation); > > } > > graphics.scale( scaling, scaling ); > > PageDrawer drawer = new PageDrawer(); > > > > > > > > --- original Nachricht Ende ---- > Jeremias Maerki
