Re: Perf problem while calling multiple times PDDocument.openProtection

Tue, 10 Apr 2012 10:58:15 -0700 

Hi,

Am 02.04.2012 17:43, schrieb Anthony:

Hello,

I'm trying to create a program which handles big numbers of encrypted PDFs.
I've seen that a very big part of the time passed in
PDDocument.openProtection is used in
"SecurityHandlersManager.getInstance()" and more specifically in
"Security.addProvider(new BouncyCastleProvider())".

My question is : why that "Security.addProvider(new
BouncyCastleProvider())" is outside the "if(instance == null) {...}" ?

Here is the original code :
     public static SecurityHandlersManager getInstance()
     {
         if(instance == null)
         {
             instance = new SecurityHandlersManager();
         }
         Security.addProvider(new BouncyCastleProvider());

         return instance;
     }

Thanks,
    Anthony


I fixed the as proposed in revision 1311890, see [1] for further details.

Thanks for the report and the solution!


BR
Andreas Lehmkühler

[1] https://issues.apache.org/jira/browse/PDFBOX-1286

Reply via email to