Hi,
Am 05.06.2012 11:58, schrieb Jens Kapitza:
Hi, currently i'am new to pdfbox
while i'am writing a *Bachelor-Thesis i found pdfbox for changeing some
pdf files
i'am using openjdk and love the generics, enums and switches on string.
while browsing the source i seen that there is something to do.
For example in PDPage PDRectangle PAGE_SIZE_A0 changeing all SIZES to an
enum much easier for later use in some further projects.
Or getAllPages() returning PDPage (using genertics)
I know that will break compatibility with JVM < 1.5,1.6,1.7 (depending
on feature)
befor i will start to submit patches the question is:
Are patches welcome?
Are there any Code-*/Convention/*?
first, each contribution/patches are welcome. The best way to do it is
create an issue (https://issues.apache.org/jira/browse/PDFBOX) and
attach patches.
PDFBOX currently is Java 5 conform and all changes has to be as well.
However we plan on moving to Java 6, presumably with a 2.0 release (as I
see it this won't happen in the next 3 month).
With Java 5 you have Generics and Enums and using Generics in PDFBOX has
started long ago. However there is enough old code base which don't. I'm
much in favor of Generics and encourage you to provide patches here.
This task will also teach you the code structure and code conventions.
Using enums is ok for new code but changing existing int (or something
else) based enumerations to enum might introduce compatibility issues.
This should only be done for a major release if there are good reasons for.
Kind regards,
Timo
--
Timo Boehme
OntoChem GmbH
H.-Damerow-Str. 4
06120 Halle/Saale
T: +49 345 4780474
F: +49 345 4780471
[email protected]
_____________________________________________________________________
OntoChem GmbH
Geschäftsführer: Dr. Lutz Weber
Sitz: Halle / Saale
Registergericht: Stendal
Registernummer: HRB 215461
_____________________________________________________________________
