[ 
https://issues.apache.org/jira/browse/PDFBOX-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13290078#comment-13290078
 ] 

Thomas Chojecki commented on PDFBOX-564:
----------------------------------------

Thx for that fix, maybe it is possible to remove that class and extend only 
from exception. :-) I never understood the purpose of that WrappedException.
                
> Change the wrapped exception to extend Exception and pass the wrapped 
> exception for more standard/better printout of wrapped exceptions
> ---------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: PDFBOX-564
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-564
>             Project: PDFBox
>          Issue Type: Improvement
>          Components: Utilities
>    Affects Versions: 1.0.0
>            Reporter: Yonas Jongkind
>            Assignee: Timo Boehme
>             Fix For: 1.8.0
>
>
> Wrapped exceptions are now handled by Java. So wrapped exception can be 
> replaced with the following code for better exception reporting/handling. 
> Including better integrations with logging utilities such as slf4j which 
> "understand" java wrapped exceptions.
> /*
>  * Licensed to the Apache Software Foundation (ASF) under one or more
>  * contributor license agreements.  See the NOTICE file distributed with
>  * this work for additional information regarding copyright ownership.
>  * The ASF licenses this file to You under the Apache License, Version 2.0
>  * (the "License"); you may not use this file except in compliance with
>  * the License.  You may obtain a copy of the License at
>  *
>  *      http://www.apache.org/licenses/LICENSE-2.0
>  *
>  * Unless required by applicable law or agreed to in writing, software
>  * distributed under the License is distributed on an "AS IS" BASIS,
>  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
>  * See the License for the specific language governing permissions and
>  * limitations under the License.
>  */
> package org.apache.pdfbox.exceptions;
> /**
>  * An exception that that holds a sub exception.
>  *
>  * Actually, this class is no longer required as this is now better suppored 
> by java.lang.Exception.
>  * 
>  * @author <a href="mailto:[email protected]";>Ben Litchfield</a>
>  * @version $Revision: 1.2 $
>  */
> public class WrappedException extends Exception
> {
>       /**
>      * constructor comment.
>      *
>      * @param e The root exception that caused this exception.
>      */
>     public WrappedException( Exception e )
>     {
>         super(e);
>     }
> }

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to