[
https://issues.apache.org/jira/browse/PDFBOX-1459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrian Nistor updated PDFBOX-1459:
----------------------------------
Description:
The problem appears in revision 1414788. I attached a one-line patch
that fixes it. This problem and the attached patch are similar the
previously fixed PDFBOX-1447 and its patch.
In method "AbstractTestAction.valid", the loop over "errors" should
break immediately after "found" is set to "true". All the iterations
after "found" is set to "true" do not perform any useful work, at best
they just set "found" again to "true".
was:
The problem appears in revision 1414788. I attached a one-line patch
that fixes it.
In method "AbstractTestAction.valid", the loop over "errors" should
break immediately after "found" is set to "true". All the iterations
after "found" is set to "true" do not perform any useful work, at best
they just set "found" again to "true".
> wasted work in AbstractTestAction.valid()
> -----------------------------------------
>
> Key: PDFBOX-1459
> URL: https://issues.apache.org/jira/browse/PDFBOX-1459
> Project: PDFBox
> Issue Type: Bug
> Reporter: Adrian Nistor
> Labels: patch, performance
> Attachments: patch.diff
>
>
> The problem appears in revision 1414788. I attached a one-line patch
> that fixes it. This problem and the attached patch are similar the
> previously fixed PDFBOX-1447 and its patch.
> In method "AbstractTestAction.valid", the loop over "errors" should
> break immediately after "found" is set to "true". All the iterations
> after "found" is set to "true" do not perform any useful work, at best
> they just set "found" again to "true".
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
