Hi, IMHO Timo's comment makes perfect sense. On the other hand wo the patch the objects were not read at all which is also not inline with the expectations. Obviously not reading a potentially malformed object will hide the error. I think a lot of the changes we are doing where new objects are read or are read in a different way will have the potential of 'breaking' previously running applications. We can only make sure that our tests pass not that all pdfs around are handled.
From a versioning point a patch release fixes a bug so 1.8.1 is fine for that. Incrementing a minor release means there is new functionality wo breaking backwards compatibility. Incrementing a major release means there is no full backwards compatibility. So if we consider that the change breaks backwards compatibility we need to increment to 2.0. I'm +1 to release as 1.8.1 and not mention possible implications. Doing that now would mean we have to do consider doing it always. Maruan Sahyoun Am 08.04.2013 um 10:01 schrieb Timo Boehme <[email protected]>: > Hi, > > +1 for releasing. > > However the committed patch for PDFBOX-1557 which makes sure all objects from > trailer will be loaded might also result in some documents, parsable by > 1.8.0, now throwing parsing exceptions because previously untouched malformed > objects are now read. While this is fine for an e.g. 1.9.0 release it is not > so expected in a pure bug fix release like this one. Maybe we should at least > mention this in the release description. > > > Best regards, > Timo > > > Am 07.04.2013 16:46, schrieb Andreas Lehmkuehler: >> Hi, >> >> a candidate for the PDFBox 1.8.1 release is available at: >> >> http://people.apache.org/~lehmi/pdfbox/1.8.1/ >> >> The release candidate is a zip archive of the sources in: >> >> http://svn.apache.org/repos/asf/pdfbox/tags/1.8.1/ >> >> The SHA1 checksum of the archive is >> 2b8bb4b3df4d5e84072cd4202acc87e09c95ba1a. >> >> Please vote on releasing this package as Apache PDFBox 1.8.1. >> The vote is open for the next 72 hours and passes if a majority of at >> least three +1 PDFBox PMC votes are cast. >> >> [ ] +1 Release this package as Apache PDFBox 1.8.1 >> [ ] -1 Do not release this package because... >> >> Here is my +1 >> >> BR >> Andreas Lehmkühler > > > -- > > Timo Boehme > OntoChem GmbH > H.-Damerow-Str. 4 > 06120 Halle/Saale > T: +49 345 4780474 > F: +49 345 4780471 > [email protected] > > _____________________________________________________________________ > > OntoChem GmbH > Geschäftsführer: Dr. Lutz Weber > Sitz: Halle / Saale > Registergericht: Stendal > Registernummer: HRB 215461 > _____________________________________________________________________ >
