[
https://issues.apache.org/jira/browse/PDFBOX-1803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Fred Hansen updated PDFBOX-1803:
--------------------------------
Attachment: PDFBOX-DateConverter-Trunk-fred.patch
PDFBOX-DateConverter-1.8-fred.patch
Proposed changes
toCalendar(String) : return null for an empty string
toCalendar(String, String[]) : return dummy value for null (instead of
returning null) ; added an example of supplying a format
toCalendar(COSString : strengthened the deprecation
parseDate directly tests for null and empty string
Improved JavaDoc for these methods
TestDateUtil
changed testExtract to testToCalendar and incorporated into it test for null
and empty strings. Test the new example of toCalendar(String, String[])
added tests for null and empty strings
> StringIndexOutOfBound on DateConverter.toCalendar
> -------------------------------------------------
>
> Key: PDFBOX-1803
> URL: https://issues.apache.org/jira/browse/PDFBOX-1803
> Project: PDFBox
> Issue Type: Bug
> Components: PDModel, Utilities
> Affects Versions: 1.8.3
> Reporter: Eric Leleu
> Priority: Minor
> Attachments: PDFBOX-DateConverter-1.8-fred.patch,
> PDFBOX-DateConverter-Trunk-fred.patch, PDFBox-DateConverter-Br18.patch,
> PDFBox-DateConverter-Trunk.patch
>
>
> Some PDF have an empty string as CreationDate & ModDate in the Information
> Dictionary.
> According to the PDF specification, this two element are optional.
> My first fix was to test the null & the empty string in the
> toCalendar(String, String[]) method and I return null if one of the both
> condition is verified.
> But according to a test case(TestDateUtil) a NullPointer is expected on null
> value of text. Can you explain why this behaviour has been adopted?
> To fixe this unexpected exception in my execution path, I have added a test
> on the empty string in the deprecated method toCalendar(String). (Patch in
> attachment)
> I'm waiting your comment before commit this patch (or change it by my first
> implementation)
> BR,
> Eric
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
