github-advanced-security[bot] commented on code in PR #533:
URL: https://github.com/apache/pdfbox/pull/533#discussion_r4028445983
##########
pdfbox/src/main/java/org/apache/pdfbox/cos/COSDocument.java:
##########
@@ -610,5 +626,115 @@
{
return documentState;
}
-
+
+ /**
+ * Xref table which also indexes its keys by internal hash, so the stored
key instance (which carries the object
+ * stream index) can be looked up without scanning; HashMap has no API for
that. Every method that can insert a
+ * key is overridden to index the inserted instance. Removals through
views are not intercepted, so the index
+ * may hold keys no longer in the table; {@link #getKey(long, int)} checks
for that.
+ */
+ private static final class XrefTable extends HashMap<COSObjectKey, Long>
Review Comment:
## CodeQL / No clone method
No clone method, yet implements Cloneable.
[Show more
details](https://github.com/apache/pdfbox/security/code-scanning/619)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
