valerybokov commented on PR #559: URL: https://github.com/apache/pdfbox/pull/559#issuecomment-6708145409
> You're contradicting yourself, your change has `return this == WORD_SEPARATOR` but you suggest to remove `WORD_SEPARATOR`. Yes we could remove `WORD_SEPARATOR` but this would lessen readability because we'd have to check for null instead. Maybe I missed something. I realize that my suggestions are mutually exclusive: either remove these methods or modify the `isWordSeparator` method. I did not suggest removing the `WORD_SEPARATOR` field. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
