evandrojr commented on PR #562:
URL: https://github.com/apache/pdfbox/pull/562#issuecomment-6800687537
Thanks for the review @THausherr . I pushed an update (fb1ee75b5b):
- Javadoc: createSignatureRectangle() in PDFTemplateBuilder now describes
both modes. By default, y is measured from the top of the template, so
the rectangle is calculated from xAxis, templateHeight - yAxis, width and
height. With the new option enabled, xAxis and yAxis are used as given
as the lower left corner, and the upper right corner is xAxis + width,
yAxis + height. The new methods in PDVisibleSignDesigner are documented
the same way.
- Naming: I agree that "custom coordinates" was too vague. I first renamed
it to "bottom left origin", but that is ambiguous for pages with
/Rotate, because the visual bottom left of a rotated page is not the
origin of the page's user space. The option is now called
useUserSpaceCoordinates(boolean) / isUseUserSpaceCoordinates(). "User
space" is the term from the PDF specification, and the javadoc states that
/Rotate is not taken into account. If you prefer another name, I'm happy
to change it.
- The title now contains the issue number: PDFBOX-6307.
PDVisibleSignDesignerTest passes (both modes covered).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
