[ 
https://issues.apache.org/jira/browse/PDFBOX-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13876653#comment-13876653
 ] 

John Hewson commented on PDFBOX-1646:
-------------------------------------

getGlyphNameFromCode doesn't ad d any new functionality that isn't already  
provided by Mapping, you can just etrieve the mapping and look up the name . 
These can be cached within FOP if you require frequent access to them.

> [PATCH] Add method for retrieving CFF bounding box from CFFFont class with 
> slight refactoring and optimization.
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: PDFBOX-1646
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-1646
>             Project: PDFBox
>          Issue Type: Improvement
>          Components: FontBox
>    Affects Versions: 1.8.2
>            Reporter: Robert Meyer
>            Assignee: Andreas Lehmkühler
>         Attachments: patch-optimize.diff, patch.diff
>
>
> I have added a method to the CFFFont class to retrieve the bounding box for a 
> character determined by an SID as well as retrieving a name. I have also 
> slightly modified the existing code so that each sid mapping can be retrieved 
> now using the SID as the key from a map. From looking around there are 
> several examples of where iterative loops are used using the original mapping 
> array:
> CFFFontROS.java:165
> CFFParser.java:876
> I haven't changed those locations yet, but they can be made in a separate 
> patch which should boost performance.
> There was a small bit of refactoring done as well just because I now retrieve 
> a renderer from two locations. These patches are part of adding OTF CFF 
> support to Apache FOP.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to