[
https://issues.apache.org/jira/browse/PDFBOX-1684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13899760#comment-13899760
]
John Hewson commented on PDFBOX-1684:
-------------------------------------
Replacing the trivial classes seems like a good idea. For 2.0.0 we're using
Java 1.6 so anything for comparability with 1.5 can be removed. I'd prefer to
see as little as possible in the utilities module as it couples unrelated code.
For example, imagine if I want to use only FontBox then I end up depending on a
utility jar which is 90% unused by FontBox.
> DateConverter source is in three places and has diverged
> --------------------------------------------------------
>
> Key: PDFBOX-1684
> URL: https://issues.apache.org/jira/browse/PDFBOX-1684
> Project: PDFBox
> Issue Type: Improvement
> Components: Utilities
> Affects Versions: 2.0.0
> Environment: Win 8, maven 3.0.5, svn 1.7.8 (r1419691), javac 1.7.0_25
> Reporter: Fred Hansen
> Priority: Minor
> Fix For: 2.0.0
>
>
> Versions of DateConverter,java are in three (3) packages: jempbox.impl,
> pdfbox.util, and xmpbox. They have diverged as updates have been made to one
> or the other.
> Date Converter is used in these modules:
> jempbox.xmp.ResourceEvent.java
> jempbox.xmp.XMPSchema.java
> pdfbox.cos.COSDictionary.java
> pdfbox.pdmodel.fdf.FDFAnnotation.java
> preflight.metadata.SynchronizedMetaDataValidation.java
> xmpbox.type.DateType.java
> The smallest library is xmpbox, so let's consider it as a home for
> DateConverter. Preflight already imports xmpbox. Pdfbox requires jempbox, so
> importing xmpbox into jempbox will satisfy both. Since xmpbox defines some
> xmp features, it seems likely that jempbox could take further advantage of
> xmpbox.
> { incorrect: Conclusion and recommendation: have a single copy of
> DateConverter in xmpbox. }
> Conclusion: create another top-level pdfbox package for DateConverter and
> other utilities that do not depend on pdfbox classes.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
