[ 
https://issues.apache.org/jira/browse/PDFBOX-1596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Green updated PDFBOX-1596:
--------------------------------

    Attachment: PDFBOX-1596.patch

Simple (yet untested) patch.

> OverlayPDF logic should be moved into a library class
> -----------------------------------------------------
>
>                 Key: PDFBOX-1596
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-1596
>             Project: PDFBox
>          Issue Type: Improvement
>          Components: Utilities
>    Affects Versions: 1.8.1
>            Reporter: James Green
>            Priority: Minor
>         Attachments: PDFBOX-1596.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> We're finding that OverlayPDF fixes problems observed when using Overlay. 
> However, with Overlay we can operate it as a library call but OverlayPDF 
> can't be particularly given we work with PDDocuments.
> I've just had someone copy the entire OverlayPDF class into one of our own 
> and modify it to accept pre-loaded PDDocuments instead of filenames. It would 
> be far more constructive to extract the core logic into a library class and 
> have the CLI class drive it.
> If we had a proper clone method it would be good to create a completely new 
> PDDocument to serve as the new returned document instead of mutating the 
> inputs too...



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to