[
https://issues.apache.org/jira/browse/PDFBOX-1914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13901938#comment-13901938
]
Tilman Hausherr edited comment on PDFBOX-1914 at 2/14/14 9:19 PM:
------------------------------------------------------------------
Done in rev 1568519 for the 2.0 version and 1568522 for the 1.8.5 version. I
also removed a deprecated method that did nothing, removed some class variables
that were not needed, and deleted "Area" and "Polygon" variables because they
were found to be useless, because integer-based, and added implementation for
function in the Gouraud shading. (Untested because there is no test file) I
kept the getFunction and setFunction calls although they are used nowhere.
Maybe they are needed if someone uses PDFBOX to build a PDF from scratch...
was (Author: tilman):
Done in rev 1568519 for the 2.0 version. I also removed a deprecated method
that did nothing, removed some class variables that were not needed, and
deleted "Area" and "Polygon" variables because they were found to be useless,
because integer-based, and added implementation for function in the Gouraud
shading. (Untested because there is no test file) I kept the getFunction and
setFunction calls although they are used nowhere. Maybe they are needed if
someone uses PDFBOX to build a PDF from scratch...
> Shading package: Move "function" methods to base class and more refactoring
> ---------------------------------------------------------------------------
>
> Key: PDFBOX-1914
> URL: https://issues.apache.org/jira/browse/PDFBOX-1914
> Project: PDFBox
> Issue Type: Improvement
> Components: Rendering
> Affects Versions: 1.8.4, 2.0.0
> Reporter: Tilman Hausherr
> Assignee: Tilman Hausherr
> Priority: Minor
> Labels: refactoring, shading
> Fix For: 1.8.5, 2.0.0
>
>
> I'm planning to move the "function" methods to the PDShadingResources class.
> Reasons: 1) duplicate code (partly introduced by myself), 2) this will allow
> me to handle functions in type 4 & 5 shading. Currently I can't, because
> these shading context classes use a common class (GouraudShadingContext), but
> the PDShadingType 4 and 5 have their function methods.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
