[ https://issues.apache.org/jira/browse/PDFBOX-1963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13922958#comment-13922958 ]
Tilman Hausherr commented on PDFBOX-1963: ----------------------------------------- Your refactoring that "needed" to be done took away the possibility to decide on the type of the BufferedImage, especially for bitonal images. Please put that back. I also don't understand why you took way the pdPage parameter away and are using a page index instead, and then get pdPage again from that. > PDFImageWriter doesn't make use of PDFStreamEngine > -------------------------------------------------- > > Key: PDFBOX-1963 > URL: https://issues.apache.org/jira/browse/PDFBOX-1963 > Project: PDFBox > Issue Type: Improvement > Components: Utilities > Affects Versions: 2.0.0 > Reporter: John Hewson > Assignee: John Hewson > Fix For: 2.0.0 > > > PDFImageWriter is a subclass of PDFStreamEngine, however it never uses any of > its functionality, the writeImage methods could be marked as static and > behave in the same manner. > The relationship between PDFImageWriter, RenderUtil, and ImageIOUtil no > longer matches its historical origins and needs to be refactored. -- This message was sent by Atlassian JIRA (v6.2#6252)