Hello, >I remember you from some time ago without details, and that one of the committers was very satisfied with your code. Yes, might be it was Thomas Chojecki. The architecture of the new features was written using very beautiful design patterns and it was working very well :)
>did Andreas already make you sign a CLA ( https://www.apache.org/licenses/ ) ? My codes have a CLA license, Tomas Chojecki have added it. At the moment some of them are committed and some of them are not (Tomas was created code review and was adding Individual CLA [2] license to them, but might be he was busy and some codes is not committed at the moment). What do you means about "signing"? Is there another procedure too? :) >This is required when you submit real code, i.e. not just a small bugfix. As I know, I have written and upload patches from 5 000 line to 10 000 line of code. For instance, when I implement PDFBOX-1766 new feature, it was for about 3500-3800 line of code. :) >what JIRA issues are still open that you wish to have committed? PDFBOX-1848 and PDFBOX-1847 >if not already there and if possible / applicable, attach a test PDF it's already done in my open issues. :) >Make sure that your code works with the current trunk, a lot was changed, although not related to signatures Off course, I will check again. As I remember Thomas Chojecki was creating code review :) We might wait for Tomas Chojecki :) Vakhtang, On Mon, Mar 10, 2014 at 10:58 AM, Tilman Hausherr <[email protected]>wrote: > Hello Vakhtang, > > I remember you from some time ago without details, and that one of the > committers was very satisfied with your code. Maybe that person will come > back later, the weekend seems to be very quiet here. > > I'm answering you that you don't get frustrated. A few thoughts: > > - did Andreas already make you sign a CLA ( https://www.apache.org/ > licenses/ ) ? This is required when you submit real code, i.e. not just a > small bugfix. > - what JIRA issues are still open that you wish to have committed? Please > name the ones with the smallest code first > - if not already there and if possible / applicable, attach a test PDF > (that isn't copyrighted except by you) or a unit test or whatever . This is > just a general thought, e.g. you wrote code to create a new type of > signature for a PDF. Then (if possible) you should also create a unit test > that creates a signature for that PDF (if possible without user > interaction), verifies that signature, modifies the PDF, and verifies the > signature again and of course fails. > - make sure that your code works with the current trunk, a lot was > changed, although not related to signatures > > Tilman > > Am 09.03.2014 18:21, schrieb Vakhtang koroghlishvili: > >> Hello, >> >> how are you? :) >> >> You know , that I have already fix and implement some issues and new >> features which was about digital signature. I have already created >> another >> new features too but I don't know if I should create this patches in the >> pdfbox example project. I think, it's time to create another project named >> sign-box or something like that. At the moment I have time and I can >> create that project with very good design architect and show you a patch >> or comitters can create that project with existence features and then we >> will add new features step by step. >> >> I will write here, what we have at the moment, and what can we add too: >> >> At the moment, if we want to use pdfbox for the document signing , we can >> only do that thing: >> >> 1. create basic digital signature with the time of CPU. *done* >> 2. create digital signature with visible signature. *done* -that was my >> >> first contribution :-) >> >> This is very poor functionality and is not easy to use. It's just in the >> project named "examples". It must have very easy API, as we sad before. >> >> I have implement and add another functionality nd created patches some >> of them. some patches of new features is not updated in the jira, because >> I >> don't now whether this must be in the example project or not. So, at the >> moment I have that functionality: >> >> >> 1. signing document with PADES-BES or PADES-BASIC profile, with CPU >> signing >> time. *done* >> >> >> 2. signing document with PADES-BES or PADES-BASIC profile, with timeStamp >> server time. Already *implemented* - I have uploaded a patch in our jira, >> >> some classes are in the "pdfbox" project and some classes are in the >> "example" project. >> >> 3. signing document with timestamp server. Already *implemented* and >> patch >> >> is uploaded in a jira ... >> >> 4. creted document secure store and PADES LTV profile implementation >> (advanced signatures!). I have already *implemented* this. I can create >> >> patch in the example project or create patch for sign-box too :) Tell me >> and I will create patch for one of them :) >> >> 5. certificate chain verification while signing process, against OCSP, >> CRL >> protocols (with advanced ocsp, crl certificate verifications too!) - I >> have >> already *implemented* this. >> >> I can create patch in the example project or create patch for sign-box and >> etc.. :-) :-) :-) >> >> >> Finally, I want tell you that I like that project and I want to help you >> as I can. I'm very well with digital signatures and I have very good >> experience with this. So, if you need, please tell me what should I do for >> this apache project? :) I am with you :) >> >> Best regards, >> >> >
