[
https://issues.apache.org/jira/browse/PDFBOX-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13939626#comment-13939626
]
John Hewson edited comment on PDFBOX-1990 at 3/18/14 6:42 PM:
--------------------------------------------------------------
This looks good, a couple of random thoughts:
1) The static factory method doesn't need the word "Lossless" in it, because
it's already in the factory name:
{code}
LosslessFactory.createLosslessFromImage(...)
{code}
vs.
{code}
LosslessFactory.createFromImage(...)
{code}
2) When naming variables for parameters in the public API, prefer short words
over abbreviations, e.g.
{code}
BufferedImage bim ---> BufferedImage image
{code}
3) Also, if a local variable name is already a short word, prefer not
abbreviating it:
{code}
Color co ---> Color color
{code}
:)
was (Author: jahewson):
This looks good, a couple of random thoughts:
1) The static factory method doesn't need the word "Lossless" in it, because
it's already in the factory name:
{code}
LosslessFactory.createLosslessFromImage(...)
{code}
vs.
{code}
LosslessFactory.createFromImage(...)
{code}
2) When naming variables for parameters in the public API, prefer short words
over abbreviations, e.g.
{code}
BufferedImage bim ---> BufferedImage image
{code}
Also, if a local variable name is already a short word, prefer not abbreviating
it:
{code}
Color co ---> Color color
{code}
:)
> Support creating PDF from lossless encoded images
> -------------------------------------------------
>
> Key: PDFBOX-1990
> URL: https://issues.apache.org/jira/browse/PDFBOX-1990
> Project: PDFBox
> Issue Type: Improvement
> Reporter: Tilman Hausherr
> Priority: Minor
>
> Currently we support the insertion of TIFF and JPEG into a PDF, but not PNG.
> We can pass a BufferedImage, but this one will be JPEG compressed which is
> not a good thing for graphics with sharp edges. I suggest that we support PNG
> as well. It is possible because the Flate Filter supports both directions.
> My implementation (coming in a few minutes) is just an RGB based start that
> begs for improvement.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
