[ https://issues.apache.org/jira/browse/PDFBOX-1991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13940607#comment-13940607 ]
John Hewson edited comment on PDFBOX-1991 at 3/19/14 4:02 PM: -------------------------------------------------------------- Perhaps, though I'd expect if we need such a measurement then it would actually be the clipping rectangle (or similar), rather than the page height. Let's leave this issue open for now until we're 100% sure that the page height isn't needed. was (Author: jahewson): Perhaps, though I'd expect if we need such a measurement then it would actually be the clipping rectangle (or similar), rather than the page height. > Shading PaintContexts should not depend on the page height > ---------------------------------------------------------- > > Key: PDFBOX-1991 > URL: https://issues.apache.org/jira/browse/PDFBOX-1991 > Project: PDFBox > Issue Type: Improvement > Components: Rendering > Affects Versions: 2.0.0 > Reporter: John Hewson > Priority: Minor > Labels: shading, shadingpattern > > I'd like to remove the page height parameter from PDPattern as soon as > possible because of doubts over its safety (i.e. the current stream being > processed may be a pattern or a form, not a page). Before I do that we need > to remove its only use, which is... > The page height is passed to all shading PaintContext subclasses but it is > only used in GouraudShadingContext. However, all other drawing in PDFBox is > done using the native PDF y-axis which is flipped via a call to > Graphics2D#scale(0, -1) but the following code in GouraudShadingContext flips > the y-axis: > v.point = new Point.Double(v.point.getX(), pageHeight + xform.getTranslateY() > - v.point.getY()); > So it seems like this could be removed and the y-axis inversion done > elsewhere with either a Matrix, AffineTransform or Grpahics2D#scale. -- This message was sent by Atlassian JIRA (v6.2#6252)