On 29 May 2014 12:37, Andreas Lehmkuehler <andr...@lehmi.de> wrote: > Hi, > > > Am 29.05.2014 11:47, schrieb Tilman Hausherr: > >> I didn't do it because I've never used overlays. And I haven't fully >> understood >> >> what you want, maybe this is a language problem on my side. And I suspect >> that >> you're asking not for one, but two or three features. (moving into class; >> PDDocument; cloning) >> >> I might help with some basic stuff, i.e. refactoring to move stuff into >> another >> class. >> >> What I'm also wondering about: your patch has >> "pdfbox/src/main/java/org/apache/pdfbox/util/Overlay.java" with only "+" >> although the file already exists. Maybe rewrite that patch, or write >> steps (in >> the JIRA, not here) what you'd like, i.e. which class should be moved >> into which >> existent or new class. >> > As far as I can remember the idea is to move most of the code from the > commandline tool class to an util class so that those stuff could be used > anywhere without using the commandline tool itself. Which leads to more or > less copying the whole OverlayPDF class to a new one. > I guess there was a discussion on the user@ or dev@ some time ago ... >
Yeah our application takes multiple PDFs and creates a final "rendered" file. It needs to append pages, and overlay pages to replicate stationary effects. All within Java code - it cannot do this using the command line for security reasons. > I'm going to put this one on my TODO list if noone else jumps in. Many thanks. > > > And attaching a "yet untested" patch is not really good motivation :-( >> > +1 Fully aware of this - if I can come up with tests I will but was working within a commercial deadline at the time.
