[ 
https://issues.apache.org/jira/browse/PDFBOX-2123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14020994#comment-14020994
 ] 

Petr Slaby commented on PDFBOX-2123:
------------------------------------

{quote}
You are checking that the 1bit image has the default decode, but in the 1bit 
handler you handle both decodes?!
{quote}
You are right, just copy pasted the condition from the 8bit version without 
thinking much about it. My fault.

> Optimize reading of 1-bit depth images in SampleImageReader
> -----------------------------------------------------------
>
>                 Key: PDFBOX-2123
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-2123
>             Project: PDFBox
>          Issue Type: Improvement
>          Components: PDModel
>    Affects Versions: 2.0.0
>            Reporter: Petr Slaby
>            Assignee: Tilman Hausherr
>             Fix For: 2.0.0
>
>         Attachments: 000008_test-scan 20121105144109807.pdf, 
> SampledImageReader.java.patch
>
>
> Reading of 1-bit depth (black and white) images in SampleImageReader can be 
> optimized. The attached patch reduces the time spent in 
> SampleImageReader#getRGBImage() from 4 seconds to 1.8 second on my notebook 
> with the attached PDF.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to