[
https://issues.apache.org/jira/browse/PDFBOX-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14034527#comment-14034527
]
John Hewson commented on PDFBOX-2145:
-------------------------------------
Generally, I only fix these sorts of things when I'm going to work on the files
in question. You're welcome to fix warnings but watch out for List vs List<T>
issues, because some of these are really issues with the design of PDFBox, for
example getAllPages() shouldn't return a PDPageNode, but the page tree is
incorrectly implemented, so it does. Also watch out for unused methods, many of
these are part of the public API but never called internally.
I'm about to fix some bugs in PDFStreamEngine etc., which haven't been worked
on in a while, so before starting I do some cleaning up to match our newer code
conventions and fix some issues which IntelliJ has detected. Generally I like
to do this prior to making functional code changes so that my commits don't end
up with whitespace changes and basic formatting edits combined with real
changes.
The old convention was to write code such as:
{code}
/* a comment */
if(x==1)
{
...
}
{code}
But we now use:
{code}
// a comment
if (x == 1)
{
...
}
{code}
Also we now have a line limit of 100 characters.
> Clean up PDFStreamEngine and PDFTextStripper
> --------------------------------------------
>
> Key: PDFBOX-2145
> URL: https://issues.apache.org/jira/browse/PDFBOX-2145
> Project: PDFBox
> Issue Type: Improvement
> Components: Text extraction
> Affects Versions: 2.0.0
> Reporter: John Hewson
> Assignee: John Hewson
> Priority: Minor
>
> PDFStreamEngine and PDFTextStripper don't really meet our coding conventions
> and have several unused methods and deprecated code which can safely be
> removed.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
