[ 
https://issues.apache.org/jira/browse/PDFBOX-2239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tim Allison updated PDFBOX-2239:
--------------------------------

    Attachment: testPDF_multiFormatEmbFiles.pdf
                multiOSEmbeddedFiles.patch

This patch doesn't address your proposed changes.  However, I thought it might 
be of use to add in relation to these changes.

I'm attaching a test file that I generated via MyEmbeddedFiles and a unit test 
to make sure that the various os-dependent files can be extracted.

While I was trying to generate a test file, I think I found that the first line 
in each of the OS-dependent setEmbeddedFileOS in PDComplexFileSpecification 
should be changed from e.g.
{noformat}COSDictionary ef = (COSDictionary)fs.getDictionaryObject( COSName.DOS 
);{noformat}
to
{noformat}COSDictionary ef = (COSDictionary)fs.getDictionaryObject( COSName.EF 
);{noformat}

Thank you, again, for your quick response to my question on the list, and for 
opening this issue!

> Add missing values to PDComplexFileSpecification
> ------------------------------------------------
>
>                 Key: PDFBOX-2239
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-2239
>             Project: PDFBox
>          Issue Type: Improvement
>          Components: PDModel
>    Affects Versions: 1.8.6, 2.0.0
>            Reporter: Andreas Lehmkühler
>            Assignee: Andreas Lehmkühler
>         Attachments: multiOSEmbeddedFiles.patch, 
> testPDF_multiFormatEmbFiles.pdf
>
>
> The class PDComplexFileSpecification needs to be improved as follows:
> - analog to "get/setFileXXX" we should add the missing 
> get/setEmbeddedFileUnicode
> - we should rename getUnicodeFile to getFileUnicode to be inline with the 
> other getters and add a setter for that value as well
> - according to the spec, the Dos, Unix and Mac mutations shouldn't be used 
> anymore, therefore we should rearrange the order in "getFilename"



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to