[ 
https://issues.apache.org/jira/browse/PDFBOX-2239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14074550#comment-14074550
 ] 

Andreas Lehmkühler commented on PDFBOX-2239:
--------------------------------------------

I've added my proposed changes to the trunk in revision 
http://svn.apache.org/r1613465 except I didn't change the order in 
getFilename().

I've included parts of [[email protected]] patch as well (the improved test 
and the test file. I'd found the setter issue too and included a similar fix). 
Thanks for the input!

I'm going top apply the patch to the 1.8 branch as well with some slight 
modifications

> Add missing values to PDComplexFileSpecification
> ------------------------------------------------
>
>                 Key: PDFBOX-2239
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-2239
>             Project: PDFBox
>          Issue Type: Improvement
>          Components: PDModel
>    Affects Versions: 1.8.6, 2.0.0
>            Reporter: Andreas Lehmkühler
>            Assignee: Andreas Lehmkühler
>         Attachments: multiOSEmbeddedFiles.patch, 
> testPDF_multiFormatEmbFiles.pdf
>
>
> The class PDComplexFileSpecification needs to be improved as follows:
> - analog to "get/setFileXXX" we should add the missing 
> get/setEmbeddedFileUnicode
> - we should rename getUnicodeFile to getFileUnicode to be inline with the 
> other getters and add a setter for that value as well
> - according to the spec, the Dos, Unix and Mac mutations shouldn't be used 
> anymore, therefore we should rearrange the order in "getFilename"



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to