[ https://issues.apache.org/jira/browse/PDFBOX-2250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14109074#comment-14109074 ]
Timo Boehme commented on PDFBOX-2250: ------------------------------------- [~tilman] your patch will treat an object from the xref table with offset 0 equally to a non-declared object id - a null object. While on the one hand for a (C) programmer this might be obvious (0==null) this is not part of the PDF specification (at least I couldn't found it). Furthermore with the ongoing xref offset healing project we try to find the correct offset for an object id - this would be prevented with treating it like a null object only because it happens to have offset 0 and not another wrong offset. Thus I'm not sure if this patch is a good idea. On the other hand offset 0 will be wrong in any case (assuming the required header) and quite seldom thus if we have a document which can be cured by this patch it might be ok. > Improve XRef self healing mechanism > ----------------------------------- > > Key: PDFBOX-2250 > URL: https://issues.apache.org/jira/browse/PDFBOX-2250 > Project: PDFBox > Issue Type: Improvement > Components: Parsing > Affects Versions: 1.8.6, 1.8.7, 2.0.0 > Reporter: Andreas Lehmkühler > Assignee: Andreas Lehmkühler > Attachments: PDFBOX-2250-107425-empty-xref.pdf, > PDFBOX-2250-110264-xref-zeronumber.pdf > > > PDFBOX-1769 introduced a "self healing" mechanism to repair corrupt XRef > offsets. But that one was just a starter and there remain a lot of issues to > be solved. I'm planing to solve at least some of them. > All fixes and improvements are targeting the non-sequential parser and I > won't port those changes to the old parser. -- This message was sent by Atlassian JIRA (v6.2#6252)