[ 
https://issues.apache.org/jira/browse/PDFBOX-1527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14117213#comment-14117213
 ] 

Glen Peterson edited comment on PDFBOX-1527 at 9/1/14 9:00 AM:
---------------------------------------------------------------

Tilman Hausherr: I've replaced the files with the verses removed.  I'm not 
trying to promote any countries or their views with the national anthems, they 
are merely a convenient way to test character sets.  It's good timing because I 
just improved table handling.

Yes PdfLayoutManager has "cellpadding" like HTML (the space between a cell 
border and the contents), but not "cellspacing" (the space between borders of 
adjacent cells).  There is a bug where it doesn't handle a negative cell 
interior width, so you have to be a little careful, but it works. 
http://blog.planbase.com/2014/08/metric-review-pdf-report.html

Questions like this are specific to PdfLayoutManager, not PDFBox, so future 
ones should go on GitHub here:
https://github.com/GlenKPeterson/PdfLayoutManager/issues

We should probably revisit merging that code into PDFBox at some point, but 
PlanBase added limitations to the scope of the Apache PDFBox contributors 
agreement which were not acceptable to the Apache Foundation.  No one is at 
fault here except possibly myself.  The license is the same, the general 
concept of the Apache Contributors Agreement is acceptable, but PlanBase is a 
for-profit company who generally doesn't want their code used by competitors.  
Limiting the scope of potential contributions is important to PlanBase.

Contributing paid development done under NDA to an open source project is a 
delicate experiment.  PlanBase is built on open source software (carefully, 
legally, and honoring the license terms), and PdfLayoutManager is what we give 
back.  If someone were to add functionality to PdfLayoutManager, or clean up 
the code, fix bugs, whatever, that might give open source participation at 
PlanBase some political capital that might be used to revisit the scope of the 
contributors agreement.  No promises.  As with any open-source project or legal 
hurdle, patience is required...

I certainly don't want to take any development effort away from PDFBox or offer 
false hope that PdfLayoutManager will ever be merged into it.  Just laying out 
the most likely path as I see it.

Constructive criticism is welcome, but please be aware that anyone could be 
watching this conversation and keep it polite and positive if your aim is to 
grease the wheels of any legal headway on this issue.  That probably goes for 
any open-source project, but certainly bears repeating here.


was (Author: [email protected]):
Tilman Hausherr: I've replaced the files with the verses removed.  I'm not 
trying to promote any countries or their views with the national anthems, they 
are merely a convenient way to test character sets.  It's good timing because I 
just improved table handling.

Yes PdfLayoutManager has "cellpadding" like HTML (the space between a cell 
border and the contents), but not "cellspacing" (the space between borders of 
adjacent cells).  There is a bug where it doesn't handle a negative cell 
interior width, so you have to be a little careful, but it works. 
http://blog.planbase.com/2014/08/metric-review-pdf-report.html

Questions like this are specific to PdfLayoutManager, not PDFBox, so future 
ones should go on GitHub here:
https://github.com/GlenKPeterson/PdfLayoutManager/issues

We should probably revisit merging that code into PDFBox at some point, but 
PlanBase added limitations to the scope of the Apache PDFBox contributors 
agreement which were not acceptable to the Apache Foundation.  No one is at 
fault here except possibly myself.  The license is the same, the general 
concept of the Apache Contributors Agreement is acceptable, but PlanBase is a 
for-profit company who doesn't want their code used by competitors.  Limiting 
the scope of potential contributions is important to PlanBase.

Contributing paid development done under NDA to an open source project is a 
delicate experiment.  PlanBase is built on open source software (carefully, 
legally, and honoring the license terms), and PdfLayoutManager is what we give 
back.  If someone were to add functionality to PdfLayoutManager, or clean up 
the code, fix bugs, whatever, that might give open source participation at 
PlanBase some political capital that might be used to revisit the scope of the 
contributors agreement.  No promises.  As with any open-source project or legal 
hurdle, patience is required...

I certainly don't want to take any development effort away from PDFBox or offer 
false hope that PdfLayoutManager will ever be merged into it.  Just laying out 
the most likely path as I see it.

Constructive criticism is welcome, but please be aware that anyone could be 
watching this conversation and keep it polite and positive if your aim is to 
grease the wheels of any legal headway on this issue.  That probably goes for 
any open-source project, but certainly bears repeating here.

> Added table cells, page breaking, line, breaking, and transliteration
> ---------------------------------------------------------------------
>
>                 Key: PDFBOX-1527
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-1527
>             Project: PDFBox
>          Issue Type: New Feature
>          Components: Writing
>    Affects Versions: 1.8.0
>            Reporter: Glen Peterson
>              Labels: features
>         Attachments: TestPdfLayoutMgr.java, test.pdf
>
>
> PlanBase and I would like to contribute our line-breaking, page-breaking, 
> table cell, and transliteration code to the PDFBox project.  I think someone 
> on the mailing list asked me to open an issue here and attach a patch, so 
> that is what I'm doing.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to