[ https://issues.apache.org/jira/browse/PDFBOX-1094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14118441#comment-14118441 ]
John Hewson edited comment on PDFBOX-1094 at 9/2/14 6:05 PM: ------------------------------------------------------------- {quote} The spec tells this about the tiles: "Its shape need not be rectangular" {quote} That's not a problem though because the tiling is always rectangular in pattern space, (after all, it has a rectangular BBox to which it is clipped). The pattern might not appear rectangular when drawn in user space, but it is the pattern matrix which is the cause of this effect, not the pattern itself (e.g. there are no non-rectangular tilings, only rectangular tilings which have been transformed to look non-rectangular). I think the problem is that we're trying to tile the user space transformed image, i.e. we're transforming using the pattern matrix at the wrong moment. Our AWT paint needs to define the rectangular tiling in pattern space but we currently are using the transformed, non-rectangular, tiling in pattern space, but then attempting to tile in rectangularly in user space. In other words, we need to apply the pattern matrix to the surface that the pattern is drawn onto, not the pattern itself. was (Author: jahewson): {quote} The spec tells this about the tiles: "Its shape need not be rectangular" {quote} That's not a problem though because the tiling is always rectangular in pattern space, (after all, it has a rectangular BBox to which it is clipped). The pattern might not appear rectangular when drawn in user space, but it is the pattern matrix which is the cause of this effect, not the pattern itself (e.g. there are no diamond tilings). I think the problem is that we're trying to tile the user space transformed image, i.e. we're transforming using the pattern matrix at the wrong moment. Our AWT paint needs to define the rectangular tiling in pattern space but we currently are using the transformed, non-rectangular, tiling in pattern space, but then attempting to tile in rectangularly in user space. In other words, we need to apply the pattern matrix to the surface that the pattern is drawn onto, not the pattern itself. > Pattern colorspace support > -------------------------- > > Key: PDFBOX-1094 > URL: https://issues.apache.org/jira/browse/PDFBOX-1094 > Project: PDFBox > Issue Type: Improvement > Components: Rendering > Affects Versions: 1.6.0 > Reporter: Andreas Lehmkühler > Priority: Minor > Attachments: ColoredTilingPaint.patch, PATTYP1.pdf, PATTYP2.pdf, > PDF32000_2008_pg737.pdf, PDFBOX-1094-065514-XStep32767.pdf, > PDFBOX-1094-094730.pdf, PDFBOX-1094-096213-p18.pdf, > PDFBOX-1094-118358-Step-32767.pdf, PDFBOX-1094-PDFBOX-269.pdf, > PDFBOX-1094-tiling_pattern.pdf-1-broken-tiles-with-ceil.png, > PDFBOX-1861-tracemonkey13.png, PDFStreamEngine.patch, PageDrawer.patch, > _pdfbox-1094-tiling_pattern.pdf-1-blurry.png, bugzilla8677511.jpg, > gs-bugzilla693653.pdf, jagpdf_doc_patterns.pdf, > jagpdf_doc_patterns.pdf-1.png, pdfbox-1094-pdf32000_2008_pg737.pdf-1.png, > pdfbox-1094-pdf32000_2008_pg737.pdf-1.png, pdfbox-1094-pdfbox-269.pdf-2.png, > pdfbox-1094-tiling_pattern.pdf-1.png, pdfbox-1094-tiling_pattern.pdf-1.png, > pdfbox-1094-tiling_pattern.pdf-1.png, pdfbox-1861-tracemonkey.pdf-13.png, > pdfbox-1861-tracemonkey.pdf-13.png, tiling_pattern.pdf > > > PDFBox doesn't support PDPattern colorspaces -- This message was sent by Atlassian JIRA (v6.3.4#6332)