[ 
https://issues.apache.org/jira/browse/PDFBOX-2447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14181763#comment-14181763
 ] 

John Hewson edited comment on PDFBOX-2447 at 10/23/14 6:49 PM:
---------------------------------------------------------------

Some feedback: please don't use backwards conditionals in patches, e.g. in the 
PDFBox source we don't write:

{{if (null == getDocumentCatalog())}}

but always:

{{if (getDocumentCatalog() == null)}}


was (Author: jahewson):
Some feedback: Please don't use backwards conditionals in patches, e.g. in the 
PDFBox source we don't write:

{{if (null == getDocumentCatalog())}}

but always:

{{if (getDocumentCatalog() == null)}}

> "Cannot save a document which has been closed" when encrypting
> --------------------------------------------------------------
>
>                 Key: PDFBOX-2447
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-2447
>             Project: PDFBox
>          Issue Type: Bug
>          Components: PDModel
>    Affects Versions: 2.0.0
>         Environment: java7 deb7
>            Reporter: Ralf Hauser
>         Attachments: patch2447.txt, patch2447a.txt
>
>
> InputStream content = ...;
>                     int keyLength = 256;
>                     AccessPermission ap = new AccessPermission();
>                     StandardProtectionPolicy spp = new 
> StandardProtectionPolicy(
>                             symmPw, symmPw, ap);
>                     spp.setEncryptionKeyLength(keyLength);
>                     document.protect(spp);
>                     ByteArrayOutputStream baos = new ByteArrayOutputStream();
>                     document.save(baos);
> in the save() the above mentioned exception is thrown (wasn't with the 
> 2013-11 snapshot)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to