[ 
https://issues.apache.org/jira/browse/PDFBOX-2460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14188040#comment-14188040
 ] 

Ralf Hauser commented on PDFBOX-2460:
-------------------------------------

testProtectionError() unfortunately lost a lot of its quality.

With my patch, it would only succeed if the code properly detected the 
application of the wrong key with the specific serial numbers.

Now it succeeds with any other IOException, so a lot of potential for false 
positives, i.e. the code may be badly broken and the test still succeeds  :(

> fix TestPublicKeyEncryption.java
> --------------------------------
>
>                 Key: PDFBOX-2460
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-2460
>             Project: PDFBox
>          Issue Type: Bug
>          Components: Utilities
>    Affects Versions: 2.0.0
>         Environment: java7 , deb7
>            Reporter: Ralf Hauser
>            Assignee: Tilman Hausherr
>             Fix For: 2.0.0
>
>         Attachments: patch2460Decryption.txt, patch2460DecryptionVerbose.txt, 
> patch2460PublicKeyTestCaseOnError.txt
>
>
> as reported by Tilman in PDFBOX-2456



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to