[ 
https://issues.apache.org/jira/browse/PDFBOX-2460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14190529#comment-14190529
 ] 

John Hewson edited comment on PDFBOX-2460 at 10/30/14 6:15 PM:
---------------------------------------------------------------

I agree we should be testing this, but I don't think we have the right approach 
yet. If we're encrypting and decrypting the files ourselves then there's no 
real point in choosing the stronger crypto offered by the JDK over the weaker 
crypto, because our goal is to unit test PDFBox, not to unit test the JDK's 
crypto (unless there is a meaningful difference in the PDF files which we 
generate, beyond just the key length).

The blockers for me currently are:
- If I disable the line {{fail("JCE unlimited strength jurisdiction policy 
files are not installed");}} then the test still passes - why? I presume this 
is because the 256-bit test hasn't been added yet?
- Is testing with key lengths > 128 actually testing anything other than the 
JDK crypto? i.e., does PDFBox do anything meaningfully different for different 
key lengths?


was (Author: jahewson):
I agree we should be testing this, but I don't think we have the right approach 
yet. If we're encrypting and decrypting the files ourselves then there's no 
real point in choosing the stronger crypto offered by the JDK over the weaker 
crypto, because our goal is to unit test PDFBox, not to unit test the JDK's 
crypto (unless there is a meaningful difference in the PDF files which we 
generate, beyond just the key length).

The blockers for me currently are:
- If I disable the line {{fail("JCE unlimited strength jurisdiction policy 
files are not installed");}} then the test still passes - why? I presume this 
is because the 256-bit test hasn't been added yet?
- Is testing with key lengths actually testing anything other than the JDK 
crypto? i.e., does PDFBox do anything meaningfully different for different key 
lengths?

> fix TestPublicKeyEncryption.java
> --------------------------------
>
>                 Key: PDFBOX-2460
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-2460
>             Project: PDFBox
>          Issue Type: Bug
>          Components: Utilities
>    Affects Versions: 2.0.0
>         Environment: java7 , deb7
>            Reporter: Ralf Hauser
>            Assignee: Tilman Hausherr
>             Fix For: 2.0.0
>
>         Attachments: patch2460Decryption.txt, patch2460DecryptionVerbose.txt, 
> patch2460PublicKeyTestCaseOnError.txt
>
>
> as reported by Tilman in PDFBOX-2456



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to