[ 
https://issues.apache.org/jira/browse/PDFBOX-2423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14320913#comment-14320913
 ] 

Tilman Hausherr edited comment on PDFBOX-2423 at 2/14/15 6:41 AM:
------------------------------------------------------------------

patch.exe requests additional rights on windows so I won't use it. I don't have 
time for this. I just applied the patch manually.

All files are different (this doesn't mean they're wrong), so it is difficult 
to tell specific stuff, but here are some as they come:
- bugzilla869140.pdf - girls room no longer pink
- K_UPMEYER_SPRING10.pdf - problem fixed
- PDFBOX-1058.pdf - complete mess on page 4?!
- PDFBOX-1451.pdf - better
- PDFBOX-2103.pdf - problem fixed
- -gs-bugzilla690467 - problem fixed- was already fixed before
- PDFBOX-994.pdf - problem fixed
- eci_altona-test-suite-v2_technical_h.pdf - improved
- PDFBOX-1577.pdf - problem fixed
- PDFBOX-2182.pdf - still not ok
- gs-bugzilla694585.pdf - problem fixed



was (Author: tilman):
patch.exe requests additional rights on windows so I won't use it. I don't have 
time for this. I just applied the patch manually.

All files are different (this doesn't mean they're wrong), so it is difficult 
to tell specific stuff, but here are some as they come:
- bugzilla869140.pdf - girls room no longer pink
- K_UPMEYER_SPRING10.pdf - problem fixed
- PDFBOX-1058.pdf - complete mess
- PDFBOX-1451.pdf - better
- PDFBOX-2103.pdf - problem fixed
- -gs-bugzilla690467 - problem fixed- was already fixed before
- PDFBOX-994.pdf - problem fixed


> Page tree handling needs rewriting
> ----------------------------------
>
>                 Key: PDFBOX-2423
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-2423
>             Project: PDFBox
>          Issue Type: Improvement
>          Components: PDModel
>    Affects Versions: 1.8.7, 2.0.0
>            Reporter: John Hewson
>            Assignee: John Hewson
>            Priority: Blocker
>             Fix For: 2.0.0
>
>         Attachments: 025957.pdf, 26101_Colors.ai-1.png, 
> 26101_Colors.ai-1.png-diff.png, Basiswissen-Vorschriften.pdf-3.png, 
> Basiswissen-Vorschriften.pdf-3.png-diff.png, 
> Basiswissen-Vorschriften.pdf-4.png, 
> Basiswissen-Vorschriften.pdf-4.png-diff.png, PDFBOX-1058.pdf-1.png, 
> PDFBOX-1058.pdf-1.png-diff.png, PDFBOX-1058.pdf-4.png, 
> PDFBOX-1058.pdf-4.png-diff.png, PDFBOX-1094-tiling_pattern.pdf, 
> PDFBOX-1711-cmyk.pdf-1.png, PDFBOX-1711-cmyk.pdf-1.png-diff.png, 
> PDFBOX-1794-vattenfall.pdf-1.png, PDFBOX-1794-vattenfall.pdf-1.png-diff.png, 
> PDFBOX-1917.pdf-1.png, PDFBOX-1917.pdf-1.png-diff.png, 
> Transparency_group_rewrite3.patch, asy-functionshading.pdf-1.png, 
> asy-functionshading.pdf-1.png-diff.png, bugzilla869140.pdf, 
> example_026.pdf-1.png, gs-bugzilla690467.pdf, gs-bugzilla694385.pdf, 
> jagpdf_doc_patterns.pdf
>
>
> The way in which PDFBox handles the Page tree needs to be rewritten, 
> preferably from scratch. Currently the document catalog returns the raw 
> objects from the page tree, wrapped in either a PDPage or PDPageNode.
> We need to abstract over the page tree and get rid of PDPageNode, we should 
> provide methods which can add/remove PDPage objects *only*. The existing 
> low-level access to the page tree is not needed at the PD-level.
> Inheritance of page properties such as crop box, resources, and rotation 
> should be reimplemented to use whatever new page tree abstraction we invent. 
> We can finally remove the old broken methods which didn't look up the 
> inheritance tree when retrieving these values.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to