[ 
https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14361024#comment-14361024
 ] 

Martin Schröder commented on PDFBOX-2576:
-----------------------------------------

Description     Resource        Path    Location        Type
Unnecessary cast from byte to int       TTFSubsetter.java       
/fontbox/src/main/java/org/apache/fontbox/ttf   line 496        Java Problem
Unnecessary cast from byte to int       TTFSubsetter.java       
/fontbox/src/main/java/org/apache/fontbox/ttf   line 498        Java Problem
Unnecessary cast from byte to int       TTFSubsetter.java       
/fontbox/src/main/java/org/apache/fontbox/ttf   line 587        Java Problem
Unnecessary cast from byte to int       TTFSubsetter.java       
/fontbox/src/main/java/org/apache/fontbox/ttf   line 587        Java Problem
Unnecessary cast from byte to int       TTFSubsetter.java       
/fontbox/src/main/java/org/apache/fontbox/ttf   line 591        Java Problem
Unnecessary cast from byte to int       TTFSubsetter.java       
/fontbox/src/main/java/org/apache/fontbox/ttf   line 591        Java Problem
Unnecessary cast from byte to int       TTFSubsetter.java       
/fontbox/src/main/java/org/apache/fontbox/ttf   line 633        Java Problem
Unnecessary cast from byte to int       TTFSubsetter.java       
/fontbox/src/main/java/org/apache/fontbox/ttf   line 633        Java Problem
Unnecessary cast from byte to long      TTFSubsetter.java       
/fontbox/src/main/java/org/apache/fontbox/ttf   line 176        Java Problem
Unnecessary cast from byte to long      TTFSubsetter.java       
/fontbox/src/main/java/org/apache/fontbox/ttf   line 1033       Java Problem
Unnecessary cast from byte to long      TTFSubsetter.java       
/fontbox/src/main/java/org/apache/fontbox/ttf   line 1034       Java Problem
Unnecessary cast from byte to long      TTFSubsetter.java       
/fontbox/src/main/java/org/apache/fontbox/ttf   line 1035       Java Problem
Unnecessary cast from byte to long      TTFSubsetter.java       
/fontbox/src/main/java/org/apache/fontbox/ttf   line 1036       Java Problem
Unnecessary cast from int to long       TTFSubsetter.java       
/fontbox/src/main/java/org/apache/fontbox/ttf   line 1028       Java Problem
Unnecessary cast from int to long       TTFSubsetter.java       
/fontbox/src/main/java/org/apache/fontbox/ttf   line 1028       Java Problem

Eclipse somehow believes that the casts are unnecessary, but removing them 
makes tests fails, so I suggest to suppress these warnings.

> Improve code quality
> --------------------
>
>                 Key: PDFBOX-2576
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-2576
>             Project: PDFBox
>          Issue Type: Task
>    Affects Versions: 2.0.0
>            Reporter: Tilman Hausherr
>         Attachments: GraphicsOperatorProcessor.patch, 
> SecuryHandlerFactory.patch, 
> org.apache.pdfbox.contentstream.operator.state.patch, 
> pdfbox-override-patch.txt, pdfbox-raw-type-patch.txt, 
> pdfcloneutility-patch.txt, pdftextstripperbyarea-patch.txt, 
> ttfsubsetter-2.patch, ttfsubsetter-patch.txt
>
>
> This is a longterm issue for the task to improve code quality, by using the 
> [SonarQube 
> report|https://analysis.apache.org/dashboard/index/org.apache.pdfbox:pdfbox-reactor],
>  hints in different IDEs, the FindBugs tool and other code quality tools.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to