[
https://issues.apache.org/jira/browse/PDFBOX-2748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14490520#comment-14490520
]
John Hewson edited comment on PDFBOX-2748 at 4/10/15 11:16 PM:
---------------------------------------------------------------
{quote}
PDFBOX-1183 isn't a critical bug. It is just annoying.
{quote}
PDFBOX-1183 is quite literally a "Critical" bug in JIRA. It's not an NPE, but
in terms of quality it's huge, it shows that nobody is doing anything serious
with PDFReader. It's especially telling that nobody has bothered to fix it.
{quote}
I don't see PDFReader as a public API.
{quote}
Well, it's declared as public. We can make it into a private one, but right now
it's public API and it's pretty pointless to argue otherwise. I agree that it's
not a good choice for an end-user to subclass.
{quote}
Maybe they'll extend PageWrapper and PDFPagePanel.
{quote}
Maybe, but those are broken by design too, see PDFBOX-1863, the reason for
closing that issue wasn't really valid, the underlying cause is a design flaw
in PDFPagePanel and not a Java graphics issue. What's telling is that nobody
wanted to fix this and PDFPagePanel remains effectively unusable for that
use-case. So PDFPagePanel isn't a viable public API either, even though it's
currently public. We should probably make this private too.
What you're saying seems to match exactly what I've been saying, that PDFReader
is a private debugging too. We'd be better off making it private and moving it
to a new private home along with PDFDebugger. While we do have some public APIs
related to PDFReader and PDFPagePanel they are so broken that we should just
get rid of them.
Combining PDFReader and PDFDebugger would be awesome as we could have visual
debugging, but the status quo doesn't sever our needs well, or our end-users
needs.
was (Author: jahewson):
{quote}
PDFBOX-1183 isn't a critical bug. It is just annoying.
{quote}
PDFBOX-1183 is quite literally a "Critical" bug in JIRA. It's not an NPE, but
in terms of quality it's huge, it shows that nobody is doing anything serious
with PDFReader. It's especially telling that nobody has bothered to fix it.
{quote}
I don't see PDFReader as a public API.
{quote}
Well, it's declared as public. We can make it into a private one, but right now
it's public API and it's pretty pointless to argue otherwise. I agree that it's
not a good choice for an end-user to subclass.
{quote}
Maybe they'll extend PageWrapper and PDFPagePanel.
{quote}
Maybe, but those are broken by design too, see PDFBOX-1863, the reason for
closing that issue wasn't really valid, the underlying cause is a design flaw
in PDFPagePanel and not a Java graphics issue. What's telling is that nobody
wanted to fix this and PDFPagePanel remains effectively unusable for that
use-case. So PDFPagePanel isn't a viable public API either, even though it's
currently public. We should probably make this private too.
What you're saying seems to match exactly what I've been saying, that PDFReader
is a private debugging tool and we'd be better off making it private and moving
it to a new private home along with PDFDebugger. While we do have some public
APIs related to PDFReader and PDFPagePanel they are so broken that we should
just get rid of them.
Combining PDFReader and PDFDebugger would be awesome as we could have visual
debugging, but the status quo doesn't sever our needs well, or our end-users
needs.
> Recent files in PDF reader
> --------------------------
>
> Key: PDFBOX-2748
> URL: https://issues.apache.org/jira/browse/PDFBOX-2748
> Project: PDFBox
> Issue Type: Improvement
> Components: Swing GUI
> Affects Versions: 2.0.0
> Reporter: khyrul bashar
> Priority: Minor
> Labels: patch
> Fix For: 2.0.0
>
> Attachments: recentfiles_pdfreader.diff
>
>
> A recently opened file list containing menu in pdf reader will be a nice
> feature in PDF reader.
> I've made a patch for this. A new package under org.apache.pdfbox.tools is
> created named util which contains the class RecentFiles so that this can be
> used in feature improvement of other GUI tools PDFBox provides.
> In RecentFiles class, file path string is saved in preference by converting
> and breaking them into byte array. To do That, I've followed this
> [post|http://www.ibm.com/developerworks/library/j-prefapi/] .
> I'm saying this to help PDFBox to make an informed decision concerning
> licences issues if there is any.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
