[
https://issues.apache.org/jira/browse/PDFBOX-2835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14595461#comment-14595461
]
Igor Savin commented on PDFBOX-2835:
------------------------------------
I took a look at org.apache.pdfbox.multipdf.Overlay.java, can't see what's so
different about it - it still has the same hardcoded output to file by filename
and private everything, so doesn't seem that any of our concerns were addressed.
Is there anything wrong with the patch provided?
> [PATCH] Make Overlay class properly extendable
> ----------------------------------------------
>
> Key: PDFBOX-2835
> URL: https://issues.apache.org/jira/browse/PDFBOX-2835
> Project: PDFBox
> Issue Type: Improvement
> Components: Utilities
> Affects Versions: 1.8.9
> Reporter: Igor Savin
>
> We are trying to implement custom logic for overlaying documents. However,
> current PDFBox implementation is excessively strictly encapsulated and it's
> not really possible. What makes things worse, overlay implementation is very
> strict about the way output gets processed. Please find attached link to the
> patch that makes overlay logic more flexible by:
> 1) Making some of the methods protected;
> 2) Moving output logic to a method that can be overridden.
> 3) Moving getting list of pages to be processed logic to a method that can be
> overridden.
> http://kiberion.net/kibertoad/0001-Modify-Overlay-class-for-improved-extensibility.patch
> If there are some adjustments that should be done or a separate version made
> for trunk - please let me know, I'll get to it immediately.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
