[ 
https://issues.apache.org/jira/browse/PDFBOX-2888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14630277#comment-14630277
 ] 

ASF subversion and git services commented on PDFBOX-2888:
---------------------------------------------------------

Commit 1691444 from [~tilman] in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1691444 ]

PDFBOX-2852: remove unused assignments
PDFBOX-2888: set allSecurityToBeRemoved to false when protect() is called and 
log a warning

>  setAllSecurityToBeRemoved(true) before calling protect() should have no 
> effect
> -------------------------------------------------------------------------------
>
>                 Key: PDFBOX-2888
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-2888
>             Project: PDFBox
>          Issue Type: Improvement
>          Components: Crypto
>    Affects Versions: 2.0.0
>            Reporter: Tilman Hausherr
>            Assignee: Tilman Hausherr
>            Priority: Minor
>             Fix For: 2.0.0
>
>
> As discussed on the mailing list:
> user [~rnibali] had a problem where a file wasn't saved with encryption. The 
> cause turned out to be that he had called
> {code}
> setAllSecurityToBeRemoved(true)
> {code}
> and then
> {code}
> protect(...)
> {code}
> Although the javadoc of both methods is clear, I see a risk that this happens 
> again, e.g. when people combine existing code.
> Solution: set allSecurityToBeRemoved to false when protect() is called and 
> log a warning.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to