[ 
https://issues.apache.org/jira/browse/PDFBOX-2922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14679828#comment-14679828
 ] 

Pei-Tang Huang commented on PDFBOX-2922:
----------------------------------------

I think I finally find out what's happened in PDFBOX-2844, the original version 
of {{PDFPageable}} retrieving format using {{printerJob.defaultPage();}} and 
never modify {{paper}} since then, the paper in tray was PORTRAIT (height > 
width), so the orientation rotation works fine here.

But since 
https://github.com/apache/pdfbox/commit/ecf69cccfa8a30e7884c56ed0d1c91b828824412
 , the {{paper}} was created from document itself, and the PDFPageable try to 
set paper size (in orientation) different from those paper loaded in tray, and 
produced wrong printing.


> Make PDFPrintable and PDFPageable extandable
> --------------------------------------------
>
>                 Key: PDFBOX-2922
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-2922
>             Project: PDFBox
>          Issue Type: Improvement
>          Components: Rendering
>    Affects Versions: 2.0.0
>            Reporter: Pei-Tang Huang
>            Assignee: John Hewson
>         Attachments: landscape.pdf, rotated_cropping_failed.jpg, success.jpg
>
>
> Would you please remove the {{final}} modifier from {{PDFPrintable}} and 
> {{PDFPageable}} so that one can extending those classes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to